On 1/25/2024 2:16 AM, Jagielski, Jedrzej wrote:
From: Nguyen, Anthony L <[email protected]>
Sent: Monday, January 22, 2024 10:19 PM
On 1/18/2024 5:43 AM, Jedrzej Jagielski wrote:
Currently big amount of the functions returning standard error codes
are of type s32. Convert them to regular ints as typdefs here are not
necessary to return standard error codes.
Suggested-by: Jacob Keller <[email protected]>
Reviewed-by: Jacob Keller <[email protected]>
Signed-off-by: Jedrzej Jagielski <[email protected]>
There's various checkpatch issues being reported:
CHECK: Alignment should match open parenthesis
ERROR: space prohibited before that ',' (ctx:WxW)
WARNING: please, no space before tabs
Seems like a number of these can be remedied.
Can they be addressed in the separate, already existing clean up patch.
Or obligatorily they must be remedied in this patch?
We shouldn't introduce anything new to be cleaned up later, which is
hard to tell with everything that pops up. My thought would be to have a
cleanup patch before this to preemptively resolve what we can, then it
would be easier to review anything that pops up here.
Thanks,
Tony
