On Thu, Feb 01, 2024 at 01:59:46PM +0100, Kurt Kanzenbach wrote:
> Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs
> from user space using the netdev trigger. The LEDs are named as
> igc-<bus><device>-<led> to be easily identified.
>
> Offloading link speed is supported. Other modes are simulated in software
> by using on/off. Tested on Intel i225.
>
> Signed-off-by: Kurt Kanzenbach <[email protected]>
> ---
>
> Changes since v1:
>
> * Add brightness_set() to allow software control (Andrew)
> * Remove offloading of activity, because the software control is more
> flexible
Please could you expand on that. Activity is quite expensive in
software, since it needs to get the statistics every 50ms and then
control the LED. So if activity can be offloaded, it should
be. Sometimes the hardware can only offload a subset of activity
indications, which is fine. It should implement those it can, and
leave the rest to software.
Andrew
