> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Kunwu > Chan > Sent: Monday, January 15, 2024 1:58 PM > To: Brandeburg, Jesse <[email protected]>; Nguyen, Anthony L > <[email protected]>; [email protected]; [email protected]; > [email protected]; [email protected] > Cc: Kunwu Chan <[email protected]>; Kunwu Chan <[email protected]>; > Kitszel, Przemyslaw <[email protected]>; > [email protected]; [email protected]; > [email protected]; Keller, Jacob E <[email protected]> > Subject: [Intel-wired-lan] [PATCH v3] igb: Fix string truncation warnings in > igb_set_fw_version > > Commit 1978d3ead82c ("intel: fix string truncation warnings") > fixes '-Wformat-truncation=' warnings in igb_main.c by using kasprintf. > > drivers/net/ethernet/intel/igb/igb_main.c:3092:53: warning：‘%d’ directive > output may be truncated writing between 1 and 5 bytes into a region of size > between 1 and 13 [-Wformat-truncation=] > 3092 | "%d.%d, 0x%08x, %d.%d.%d", > | ^~ > drivers/net/ethernet/intel/igb/igb_main.c:3092:34: note：directive argument in > the range [0, 65535] > 3092 | "%d.%d, 0x%08x, %d.%d.%d", > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/ethernet/intel/igb/igb_main.c:3092:34: note：directive argument in > the range [0, 65535] > drivers/net/ethernet/intel/igb/igb_main.c:3090:25: note：‘snprintf’ output > between 23 and 43 bytes into a destination of size 32 > > kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. > > Fix this warning by using a larger space for adapter->fw_version, > and then fall back and continue to use snprintf. > > Fixes: 1978d3ead82c ("intel: fix string truncation warnings") > Signed-off-by: Kunwu Chan <[email protected]> > Cc: Kunwu Chan <[email protected]> > Suggested-by: Jakub Kicinski <[email protected]> > --- > v2: Fall back to use snprintf and a larger space,as suggested by > https://lore.kernel.org/all/[email protected]/ > v3: Add detailed warnings to the commit msg ,no functional change > --- > drivers/net/ethernet/intel/igb/igb.h | 2 +- > drivers/net/ethernet/intel/igb/igb_main.c | 35 ++++++++++++----------- > 2 files changed, 19 insertions(+), 18 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
