> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Jedrzej Jagielski > Sent: Wednesday, January 31, 2024 4:34 PM > To: [email protected] > Cc: [email protected]; Jagielski, Jedrzej <[email protected]>; > Nguyen, Anthony L <[email protected]>; Simon Horman > <[email protected]>; Dan Carpenter <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next v5 3/3] ixgbe: Clarify the values > of the returning status > > Converting s32 functions to regular int in the previous patch of the series > caused triggering smatch warnings about missing error code. > > New smatch warnings: > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2884 ixgbe_get_lcd_t_x550em() > warn: missing error code? 'status' > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:3130 > ixgbe_enter_lplu_t_x550em() warn: missing error code? 'status' > > Old smatch warnings: > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2890 ixgbe_get_lcd_t_x550em() > warn: missing error code? 'status' > > Fix it by clearly stating returning error code as 0. > > Reported-by: kernel test robot <[email protected]> > Reported-by: Dan Carpenter <[email protected]> > Closes: https://lore.kernel.org/r/[email protected]/ > Reviewed-by: Simon Horman <[email protected]> > Signed-off-by: Jedrzej Jagielski <[email protected]> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
