Dear Tony Nguyen, Thanks for your review of my patch, I'm working to improve it.
On Wed, 2024-02-07 at 13:43 -0800, Tony Nguyen wrote: > On 1/27/2024 9:48 AM, Ernesto Castellotti wrote: > > Added support for 1000BASE-BX, i.e. Gigabit Ethernet over single strand > > of single-mode fiber). > > The initialization of a 1000BASE-BX SFP is the same as 1000BASE-SX/LX > > with the only difference that the Bit Rate Nominal Value must be > > checked to make sure it is a Gigabit Ethernet transceiver, as > > described > > by the SFF-8472 specification. > > > > Some nits on the patch... Could you be more explicit in this comment? Kind regards, Ernesto
