On 2/7/2024 3:07 PM, Alexander Lobakin wrote:
From: Lukasz Plachno <[email protected]>
Date: Tue, 6 Feb 2024 17:33:37 +0100
From: Jakub Buchocki <[email protected]>
Add support for 'flow-type ether' Flow Director rules via ethtool.
Create packet segment info for filter configuration based on ethtool
command parameters. Reuse infrastructure already created for
ipv4 and ipv6 flows to convert packet segment into
extraction sequence, which is later used to program the filter
inside Flow Director block of the Rx pipeline.
[...]
diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c
b/drivers/net/ethernet/intel/ice/ice_fdir.c
index 1f7b26f38818..5fe0bad00fd7 100644
--- a/drivers/net/ethernet/intel/ice/ice_fdir.c
+++ b/drivers/net/ethernet/intel/ice/ice_fdir.c
@@ -4,6 +4,8 @@
#include "ice_common.h"
/* These are training packet headers used to program flow director filters. */
+static const u8 ice_fdir_eth_pkt[22] = {0};
I believe this zeroing is not needed, just declare it and the compiler
will zero it automatically.
{0}; will be removed in V6
[...]
@@ -97,6 +100,12 @@ struct ice_rx_flow_userdef {
u16 flex_fltr;
};
+struct ice_fdir_eth {
+ u8 dst[ETH_ALEN];
+ u8 src[ETH_ALEN];
+ __be16 type;
+};
This is clearly `struct ethhdr`, please remove this duplicating
definition and just use the generic structure.
I will fix that in V6, thank you for catching that.
Regards,
Łukasz
