> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Wojciech Drewek > Sent: Monday, February 5, 2024 6:34 PM > To: [email protected] > Cc: [email protected]; [email protected]; [email protected]; > Stillwell Jr, Paul M <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; [email protected] > Subject: [Intel-wired-lan] [PATCH iwl-next v5 1/2] ice: Remove and readd > netdev during devlink reload > > Recent changes to the devlink reload (commit 9b2348e2d6c9 > ("devlink: warn about existing entities during reload-reinit")) > force the drivers to destroy devlink ports during reinit. > Adjust ice driver to this requirement, unregister netdvice, destroy > devlink port. ice_init_eth() was removed and all the common code > between probe and reload was moved to ice_load(). > > During devlink reload we can't take devl_lock (it's already taken) > and in ice_probe() we have to lock it. Use devl_* variant of the API > which does not acquire and release devl_lock. Guard ice_load() > with devl_lock only in case of probe. > > Suggested-by: Jiri Pirko <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > Reviewed-by: Vadim Fedorenko <[email protected]> > Reviewed-by: Simon Horman <[email protected]> > Reviewed-by: Brett Creeley <[email protected]> > Signed-off-by: Wojciech Drewek <[email protected]> > --- > v2: empty init removed in ice_devlink_reinit_up > v3: refactor locking pattern as Brett suggested > v4: fix wrong function name in commit message > v5: move debugfs changes to separate commit > --- > drivers/net/ethernet/intel/ice/ice.h | 2 + > drivers/net/ethernet/intel/ice/ice_devlink.c | 68 ++++++- > drivers/net/ethernet/intel/ice/ice_main.c | 186 ++++++------------- > 3 files changed, 125 insertions(+), 131 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
