>-----Original Message-----
>From: Intel-wired-lan <[email protected]> On Behalf Of
>Fijalkowski, Maciej
>Sent: Tuesday, February 6, 2024 6:12 PM
>To: [email protected]
>Cc: [email protected]; Fijalkowski, Maciej
><[email protected]>; Nguyen, Anthony L
><[email protected]>; Simon Horman <[email protected]>;
>Karlsson, Magnus <[email protected]>
>Subject: [Intel-wired-lan] [PATCH v2 iwl-net 1/2] i40e: avoid double calling
>i40e_pf_rxq_wait()
>
>Currently, when interface is being brought down and
>i40e_vsi_stop_rings() is called, i40e_pf_rxq_wait() is called two times, which
>is
>wrong. To showcase this scenario, simplified call stack looks as follows:
>
>i40e_vsi_stop_rings()
> i40e_control wait rx_q()
> i40e_control_rx_q()
> i40e_pf_rxq_wait()
> i40e_vsi_wait_queues_disabled()
> i40e_pf_rxq_wait() // redundant call
>
>To fix this, let us s/i40e_control_wait_rx_q/i40e_control_rx_q within
>i40e_vsi_stop_rings().
>
>Fixes: 65662a8dcdd0 ("i40e: Fix logic of disabling queues")
>Reviewed-by: Simon Horman <[email protected]>
>Signed-off-by: Maciej Fijalkowski <[email protected]>
>---
> drivers/net/ethernet/intel/i40e/i40e_main.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
Tested-by: Chandan Kumar Rout <[email protected]> (A Contingent Worker at
Intel)
