From: Alan Brady <[email protected]> Date: Wed, 7 Feb 2024 16:42:43 -0800
> From: Emil Tantilov <[email protected]> > > Fix softirq's not being handled during napi_schedule() call when > receiving marker packets for queue disable by disabling local bottom > half. > > The issue can be seen on ifdown: > NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!! > > Using ftrace to catch the failing scenario: > ifconfig [003] d.... 22739.830624: softirq_raise: vec=3 [action=NET_RX] > <idle>-0 [003] ..s.. 22739.831357: softirq_entry: vec=3 [action=NET_RX] > > No interrupt and CPU is idle. > > After the patch, with BH locks: Minor: local_bh_{en,dis}able() are not "BH locks", it's BH enabling/disabling. It doesn't lock/unlock anything. > ifconfig [003] d.... 22993.928336: softirq_raise: vec=3 [action=NET_RX] > ifconfig [003] ..s1. 22993.928337: softirq_entry: vec=3 [action=NET_RX] > > Fixes: c2d548cad150 ("idpf: add TX splitq napi poll support") > Reviewed-by: Jesse Brandeburg <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > Signed-off-by: Emil Tantilov <[email protected]> > Signed-off-by: Alan Brady <[email protected]> Thanks, Olek
