On 1/4/2024 16:16, Vitaly Lifshits wrote:
On some Meteor Lake systems accessing the PHY via the MDIO interface may result in an MDI error. This issue happens sporadically and in most cases a second access to the PHY via the MDIO interface results in success.As a workaround, introduce a retry counter which is set to 3 on Meteor Lake systems. The driver will only return an error if 3 consecutive PHY access attempts fail. The retry mechanism is disabled in specific flows, where MDI errors are expected. Fixes: cc23f4f0b6b9 ("e1000e: Add support for Meteor Lake") Suggested-by: Nikolay Mushayev <[email protected]> Co-developed-by: Nir Efrati <[email protected]> Signed-off-by: Nir Efrati <[email protected]> Signed-off-by: Vitaly Lifshits <[email protected]> --- v4: rebase to latest changes in dev-queue v3: rebase to dev-queue branch v2: fix checkpatch errors v1: initial version --- drivers/net/ethernet/intel/e1000e/hw.h | 2 + drivers/net/ethernet/intel/e1000e/ich8lan.c | 33 ++++ drivers/net/ethernet/intel/e1000e/phy.c | 186 ++++++++++++-------- drivers/net/ethernet/intel/e1000e/phy.h | 2 + 4 files changed, 151 insertions(+), 72 deletions(-)
Tested-by: Naama Meir <[email protected]>
