> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Simon Horman > Sent: Monday, February 19, 2024 10:22 AM > To: Brandeburg, Jesse <[email protected]> > Cc: [email protected]; Eric Dumazet <[email protected]>; Nguyen, > Anthony L <[email protected]>; Brady, Alan > <[email protected]>; Jakub Kicinski <[email protected]>; intel-wired- > [email protected]; Paolo Abeni <[email protected]>; David S. Miller > <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 2/2] net: intel: implement > modern PM ops declarations > > On Sat, Feb 10, 2024 at 02:01:09PM -0800, Jesse Brandeburg wrote: > > Switch the Intel networking drivers to use the new power management > > ops declaration formats and macros, which allows us to drop > > __maybe_unused, as well as a bunch of ifdef checking CONFIG_PM. > > > > This is safe to do because the compiler drops the unused functions, > > verified by checking for any of the power management function symbols > > being present in System.map for a build without CONFIG_PM. > > > > If a driver has runtime PM, define the ops with pm_ptr(), and if the > > driver has Simple PM, use pm_sleep_ptr(), as well as the new versions > > of the macros for declaring the members of the pm_ops structs. > > > > Checked with network-enabled allnoconfig, allyesconfig, allmodconfig > > on x64_64. > > > > Reviewed-by: Alan Brady <[email protected]> > > Signed-off-by: Jesse Brandeburg <[email protected]> > > Reviewed-by: Simon Horman <[email protected]>
Tested-by: Rafal Romanowski <[email protected]>
