On 2/22/24 15:50, Maciej Fijalkowski wrote:
1. pcaps are free'd right after AQ routines are done, no need for devm_'s 2. a test frame for loopback test in ethtool -t is destroyed at the end of the test so we don't need devm_ here either.Signed-off-by: Maciej Fijalkowski <[email protected]> --- drivers/net/ethernet/intel/ice/ice_common.c | 23 +++++++++----------- drivers/net/ethernet/intel/ice/ice_ethtool.c | 4 ++-- 2 files changed, 12 insertions(+), 15 deletions(-)
nice, thank you! BTW, we are committed to using Scope Based Resource Management [1] even in the OOT driver, so you could consider that for future IWL submissions :) [1] https://lwn.net/Articles/934679/ I'm also happy with this as-is too, so: Reviewed-by: Przemek Kitszel <[email protected]>
