> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of 
> Maciej Fijalkowski
> Sent: Friday, February 23, 2024 9:36 PM
> To: [email protected]
> Cc: [email protected]; Fijalkowski, Maciej 
> <[email protected]>; Nguyen, Anthony L 
> <[email protected]>; Karlsson, Magnus <[email protected]>; 
> Kitszel, Przemyslaw <[email protected]>
> Subject: [Intel-wired-lan] [PATCH v2 iwl-next 1/3] ice: do not disable Tx 
> queues twice in ice_down()
>
> ice_down() clears QINT_TQCTL_CAUSE_ENA_M bit twice, which is not
> necessary. First clearing happens in ice_vsi_dis_irq() and second in
> ice_vsi_stop_tx_ring() - remove the first one.
>
> While at it, make ice_vsi_dis_irq() static as ice_down() is the only
> current caller of it.
>
> Signed-off-by: Maciej Fijalkowski <[email protected]>
> ---
 > drivers/net/ethernet/intel/ice/ice_lib.c  | 55 -----------------------
 > drivers/net/ethernet/intel/ice/ice_lib.h  |  2 -
 > drivers/net/ethernet/intel/ice/ice_main.c | 44 ++++++++++++++++++
 > 3 files changed, 44 insertions(+), 57 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <[email protected]> (A 
Contingent worker at Intel)

Reply via email to