> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Przemek Kitszel > Sent: Tuesday, February 27, 2024 8:01 PM > To: [email protected] > Cc: Nebojsa Stevanovic <[email protected]>; > [email protected]; Czapnik, Lukasz <[email protected]>; Lobakin, > Aleksander <[email protected]>; Nguyen, Anthony L > <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Keller, Jacob E <[email protected]>; > Christian Rohmann <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net] ice: fix stats being updated by > way too large values > > Simplify stats accumulation logic to fix the case where we don't take > previous stat value into account, we should always respect it. > > Main netdev stats of our PF (Tx/Rx packets/bytes) were reported orders of > magnitude too big during OpenStack reconfiguration events, possibly other > reconfiguration cases too. > > The regression was reported to be between 6.1 and 6.2, so I was almost > certain that on of the two "preserve stats over reset" commits were the > culprit. While reading the code, it was found that in some cases we will > increase the stats by arbitrarily large number (thanks to ignoring "-prev" > part of condition, after zeroing it). > > Note that this fixes also the case where we were around limits of u64, but > that was not the regression reported. > > Full disclosure: I remember suggesting this particular piece of code to > Ben a few years ago, so blame on me. > > Fixes: 2fd5e433cd26 ("ice: Accumulate HW and Netdev statistics over reset") > Reported-by: Nebojsa Stevanovic <[email protected]> > Link: > https://lore.kernel.org/intel-wired-lan/vi1pr02mb439744dedaa7b59b9a2833fe91...@vi1pr02mb4397.eurprd02.prod.outlook.com > Reported-by: Christian Rohmann <[email protected]> > Link: > https://lore.kernel.org/intel-wired-lan/[email protected] > Reviewed-by: Jacob Keller <[email protected]> > Signed-off-by: Przemek Kitszel <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_main.c | 24 +++++++++++------------ > 1 file changed, 11 insertions(+), 13 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
