On Wed, Mar 06, 2024 at 05:14:12PM -0600, Bjorn Helgaas wrote:
> [+cc Paul for __maybe_unused cleanup]
>
> On Tue, Mar 05, 2024 at 06:50:21PM -0800, Jesse Brandeburg wrote:
> > The igb driver was pre-declaring tons of functions just so that it could
> > have an early declaration of the pci_driver struct.
> >
> > Delete a bunch of the declarations and move the struct to the bottom of the
> > file, after all the functions are declared.
>
> Nice fix, that was always annoying.
>
> Seems like there's an opportunity to drop some of the __maybe_unused
> annotations:
>
> static int __maybe_unused igb_suspend(struct device *dev)
>
> after 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones").
>
> I don't know if SET_RUNTIME_PM_OPS() makes __maybe_unused unnecessary
> or not.
Sorry, should have read 2/2 first ;)
