> -----Original Message----- > From: Paul Menzel <[email protected]> > Sent: Wednesday, March 13, 2024 11:58 AM > To: Loktionov, Aleksandr <[email protected]> > Cc: [email protected]; Nguyen, Anthony L > <[email protected]>; [email protected]; Kitszel, > Przemyslaw <[email protected]>; Kubalewski, Arkadiusz > <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] i40e: fix vf may > be used uninitialized in this function warning > > Dear Aleksandr, > > > Am 13.03.24 um 10:56 schrieb Aleksandr Loktionov: > > To fix the regression introduced by commit 52424f974bc5, which > causes > > servers hang in very hard to reproduce conditions with resets > races. > > Using two sources for the information is the root cause. > > In this function before the fix bumping v didn't mean bumping vf > > pointer. But the code used this variables interchangeably, so > staled > > vf could point to different/not intended vf. > > > > Remove redundant "v" variable and iterate via single VF pointer > across > > whole function instead to guarantee VF pointer validity. > > > > Fixes: 52424f974bc5 ("i40e: Fix VF hang when reset is triggered > on > > another VF") > > Signed-off-by: Aleksandr Loktionov > <[email protected]> > > Reviewed-by: Arkadiusz Kubalewski > <[email protected]> > > Reviewed-by: Przemek Kitszel <[email protected]> > > --- > > v1 -> v2: commit message change > > Thank you very much. No need to resend, but I find it also always > useful to have the exact warning pasted in the commit message. > The warning is exactly "vf may be used uninitialized in this function" it's already in the title. What you suggest me to do? Thank you
> […] > > > --- > > .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 34 +++++++++--- > ------- > > 1 file changed, 16 insertions(+), 18 deletions(-) > > Reviewed-by: Paul Menzel <[email protected]> > > > Kind regards, > > Paul
