On Mon, Feb 26, 2024 at 01:34:48PM +0000, Simon Horman wrote: > On Thu, Feb 22, 2024 at 01:39:55PM +0100, Michal Swiatkowski wrote: > > In case of traffic going from the VF (so ingress for port representor) > > source VSI should be consider during packet classification. It is > > needed for hardware to not match packets from different ports with > > filters added on other port. > > > > It is only for "from VF" traffic, because other traffic direction > > doesn't have source VSI. > > > > Set correct ::src_vsi in rule_info to pass it to the hardware filter. > > > > For example this rule should drop only ipv4 packets from eth10, not from > > the others VF PRs. It is needed to check source VSI in this case. > > $tc filter add dev eth10 ingress protocol ip flower skip_sw action drop > > > > Reviewed-by: Jedrzej Jagielski <[email protected]> > > Reviewed-by: Sridhar Samudrala <[email protected]> > > Signed-off-by: Michal Swiatkowski <[email protected]> > > Hi Michal, > > Should this be treated as a fix: have a Fixes tag; be targeted at 'iwl'? > > That notwithstanding, this look good to me. > > Reviewed-by: Simon Horman <[email protected]> > > ...
Thanks Simon, you are right, it will go to net with correct fixes tag. Thanks, Michal
