> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Przemek Kitszel > Sent: Tuesday, March 5, 2024 9:32 PM > To: [email protected] > Cc: [email protected]; Czapnik, Lukasz <[email protected]>; > Kubiak, Michal <[email protected]>; Nguyen, Anthony L > <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Dan Carpenter <[email protected]>; > Shannon Nelson <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net] ixgbe: avoid sleeping allocation > in ixgbe_ipsec_vf_add_sa() > > Change kzalloc() flags used in ixgbe_ipsec_vf_add_sa() to GFP_ATOMIC, to > avoid sleeping in IRQ context. > > Dan Carpenter, with the help of Smatch, has found following issue: > The patch eda0333ac293: "ixgbe: add VF IPsec management" from Aug 13, > 2018 (linux-next), leads to the following Smatch static checker > warning: drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c:917 > ixgbe_ipsec_vf_add_sa() > warn: sleeping in IRQ context > > The call tree that Smatch is worried about is: > ixgbe_msix_other() <- IRQ handler > -> ixgbe_msg_task() > -> ixgbe_rcv_msg_from_vf() > -> ixgbe_ipsec_vf_add_sa() > > Reported-by: Dan Carpenter <[email protected]> > Link: > https://lore.kernel.org/intel-wired-lan/[email protected] > Reviewed-by: Michal Kubiak <[email protected]> > Signed-off-by: Przemek Kitszel <[email protected]> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
