On 3/15/2024 2:20 AM, Ivan Vecera wrote:
...
-static inline u32 i40e_buildreg_itr(const int type, u16 itr)
+/**
+ * i40e_buildreg_itr - build a value for writing to I40E_PFINT_DYN_CTLN
register
+ * @itr_idx - interrupt throttling index
+ * @interval - interrupt throttling interval value in usecs
+ * @force_swint - force software interrupt
nit: kdoc doesn't like this style
New warnings added
1a2,4
> drivers/net/ethernet/intel/i40e/i40e_txrx.c:2650: warning: Function
parameter or struct member 'itr_idx' not described in 'i40e_buildreg_itr'
> drivers/net/ethernet/intel/i40e/i40e_txrx.c:2650: warning: Function
parameter or struct member 'interval' not described in 'i40e_buildreg_itr'
> drivers/net/ethernet/intel/i40e/i40e_txrx.c:2650: warning: Function
parameter or struct member 'force_swint' not described in
'i40e_buildreg_itr'
Per-file breakdown
Thanks,
Tony
+ *
+ * The function builds a value for I40E_PFINT_DYN_CTLN register that
+ * is used to update interrupt throttling interval for specified ITR index
+ * and optionally enforces a software interrupt. If the @itr_idx is equal
+ * to I40E_ITR_NONE then no interval change is applied and only @force_swint
+ * parameter is taken into account. If the interval change and enforced
+ * software interrupt are not requested then the built value just enables
+ * appropriate vector interrupt.
+ **/
+static u32 i40e_buildreg_itr(enum i40e_dyn_idx itr_idx, u16 interval,
+ bool force_swint)
{
u32 val;
