> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Pavan Kumar Linga > Sent: Wednesday, March 20, 2024 5:09 PM > To: [email protected] > Cc: Tantilov, Emil S <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Hay, Joshua A <[email protected]>; > Daniele, Salvatore <[email protected]>; Nemeth, Balazs > <[email protected]>; Linga, Pavan Kumar > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net] idpf: fix kernel panic on unknown > packet types > > From: Joshua Hay <[email protected]> > > In the very rare case where a packet type is unknown to the driver, > idpf_rx_process_skb_fields would return early without calling > eth_type_trans to set the skb protocol / the network layer handler. > This is especially problematic if tcpdump is running when such a > packet is received, i.e. it would cause a kernel panic. > > Instead, call eth_type_trans for every single packet, even when > the packet type is unknown. > > Fixes: 3a8845af66ed ("idpf: add RX splitq napi poll support") > Reported-by: Balazs Nemeth <[email protected]> > Signed-off-by: Joshua Hay <[email protected]> > Reviewed-by: Jesse Brandeburg <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > Tested-by: Salvatore Daniele <[email protected]> > Signed-off-by: Pavan Kumar Linga <[email protected]> > --- > drivers/net/ethernet/intel/idpf/idpf_txrx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c > b/drivers/net/ethernet/intel/idpf/idpf_txrx.c > index 2f8ad79ae3f0..017a081d8580 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c > +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
Tested-by: Krishneil Singh [email protected]
