> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of Bjorn
> Helgaas
> Sent: Monday, March 25, 2024 3:30 PM
> To: Brandeburg, Jesse <[email protected]>; Nguyen, Anthony L
> <[email protected]>; David S . Miller <[email protected]>; Eric
> Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni
> <[email protected]>
> Cc: Neftin, Sasha <[email protected]>; [email protected]; Wysocki,
> Rafael J <[email protected]>; [email protected]; Bjorn
> Helgaas <[email protected]>; [email protected]; Zheng Yan
> <[email protected]>; Konstantin Khlebnikov <[email protected]>;
> Heiner Kallweit <[email protected]>
> Subject: [Intel-wired-lan] [PATCH 2/3] igb: Remove redundant runtime resume
> for ethtool_ops
>
> From: Bjorn Helgaas <[email protected]>
>
> 749ab2cd1270 ("igb: add basic runtime PM support") added
> ethtool_ops.begin() and .complete(), which used pm_runtime_get_sync() to
> resume suspended devices before any ethtool_ops callback and allow suspend
> after it completed.
>
> Subsequently, f32a21376573 ("ethtool: runtime-resume netdev parent before
> ethtool ioctl ops") added pm_runtime_get_sync() in the dev_ethtool() path,
> so the device is resumed before any ethtool_ops callback even if the driver
> didn't supply a .begin() callback.
>
> Remove the .begin() and .complete() callbacks, which are now redundant
> because dev_ethtool() already resumes the device.
>
>Signed-off-by: Bjorn Helgaas <[email protected]>
>---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
Tested-by: Sunitha Mekala <[email protected]> (A Contingent worker at
Intel)
