> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Michal Swiatkowski
> Sent: Friday, March 15, 2024 4:38 PM
> To: [email protected]
> Cc: [email protected]; Drewek, Wojciech
> <[email protected]>; Michal Swiatkowski
> <[email protected]>
> Subject: [Intel-wired-lan] [iwl-net v1 2/2] ice: tc: allow zero flags in
> parsing tc
> flower
>
> The check for flags is done to not pass empty lookups to adding switch rule
> functions. Since metadata is always added to lookups there is no need to
> check against the flag.
>
> It is also fixing the problem with such rule:
> $ tc filter add dev gtp_dev ingress protocol ip prio 0 flower \
> enc_dst_port 2123 action drop
> Switch block in case of GTP can't parse the destination port, because it
> should always be set to GTP specific value. The same with ethertype. The
> result is that there is no other matching criteria than GTP tunnel. In this
> case
> flags is 0, rule can't be added only because of defensive check against flags.
>
> Fixes: 9a225f81f540 ("ice: Support GTP-U and GTP-C offload in switchdev")
> Reviewed-by: Wojciech Drewek <[email protected]>
> Signed-off-by: Michal Swiatkowski <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_tc_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Sujai Buvaneswaran <[email protected]>
