On Tue, Apr 23, 2024 at 12:24:54PM +0200, Corinna Vinschen wrote:
> During successful probe, igc logs this:
>
> [ 5.133667] igc 0000:01:00.0 (unnamed net_device) (uninitialized): PHC
> added
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> The reason is that igc_ptp_init() is called very early, even before
> register_netdev() has been called. So the netdev_info() call works
> on a partially uninitialized netdev.
>
> Fix this by calling igc_ptp_init() after register_netdev(), right
> after the media autosense check, just as in igb. Add a comment,
> just as in igb.
The network stack can start sending and receiving packet before
register_netdev() returns. This is typical of NFS root for example. Is
there anything in igc_ptp_init() which could cause such packet
transfers to explode?
A better fix is to allocate the device name earlier. A few drivers
call dev_alloc_name().
Andrew
