> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Asbjørn Sloth Tønnesen > Sent: Tuesday, April 16, 2024 8:14 PM > To: [email protected] > Cc: [email protected]; [email protected]; Eric Dumazet > <[email protected]>; Nguyen, Anthony L > <[email protected]>; Asbjørn Sloth Tønnesen <[email protected]>; > Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; > David S. Miller <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next] ice: flower: validate control > flags > > This driver currently doesn't support any control flags. > > Use flow_rule_has_control_flags() to check for control flags, such as can be > set through `tc flower ... ip_flags frag`. > > In case any control flags are masked, flow_rule_has_control_flags() sets a NL > extended error message, and we return -EOPNOTSUPP. > > Only compile-tested. > > Signed-off-by: Asbjørn Sloth Tønnesen <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_tc_lib.c | 4 ++++ > 1 file changed, 4 insertions(+) >
Hi, I have tested this patch in upstream kernel - 6.9.0-rc5+ and observing no effect while adding tc flow rule with control flags. 'Not supported' error is not shown while adding the below tc rule. [root@cbl-mariner ~]# tc qdisc add dev ens5f0np0 ingress [root@cbl-mariner ~]# [root@cbl-mariner ~]# tc filter add dev ens5f0np0 ingress protocol ip flower ip_flags frag/firstfrag action drop [root@cbl-mariner ~]# [root@cbl-mariner ~]# ethtool -i ens5f0np0 driver: ice version: 6.9.0-rc5+ firmware-version: 4.40 0x8001c967 1.3534.0 expansion-rom-version: bus-info: 0000:b1:00.0 supports-statistics: yes supports-test: yes supports-eeprom-access: yes supports-register-dump: yes supports-priv-flags: yes Same behavior is observed with iavf driver on VF as well. Regards, Sujai B
