Hi Asbjørn, HW offload is not supported on the i40e interface. This patch cannot be tested on i40e interface.
Regards, Sujai B > -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Asbjørn Sloth Tønnesen > Sent: Tuesday, April 16, 2024 8:13 PM > To: [email protected] > Cc: [email protected]; [email protected]; Eric Dumazet > <[email protected]>; Nguyen, Anthony L > <[email protected]>; Asbjørn Sloth Tønnesen <[email protected]>; > Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; > David S. Miller <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next] i40e: flower: validate control > flags > > This driver currently doesn't support any control flags. > > Use flow_rule_has_control_flags() to check for control flags, such as can be > set through `tc flower ... ip_flags frag`. > > In case any control flags are masked, flow_rule_has_control_flags() sets a NL > extended error message, and we return -EOPNOTSUPP. > > Only compile-tested. > > Signed-off-by: Asbjørn Sloth Tønnesen <[email protected]> > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c > b/drivers/net/ethernet/intel/i40e/i40e_main.c > index 0bdcdea0be3e..e219f757820d 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -8643,6 +8643,10 @@ static int i40e_parse_cls_flower(struct i40e_vsi > *vsi, > > flow_rule_match_control(rule, &match); > addr_type = match.key->addr_type; > + > + if (flow_rule_has_control_flags(match.mask->flags, > + f->common.extack)) > + return -EOPNOTSUPP; > } > > if (addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) { > -- > 2.43.0
