On 5/6/2024 4:35 AM, Przemek Kitszel wrote:
In general do not add a blank line after Fixes tag. Someone could complain that i40e driver had a bug prior to the cited core commit, but for more practical purposes I find it good as is. When you are a sender of the patch, it's good to place your Signed-off as a last tag.
I appreciate your effort to minimize changed lines to have a fix better visible, however we avoid forward declarations in .c files. I would split this into two commits - the first to just factor out/move functions w/o functional changes, then second one with a logic fix.
Thanks for the review. I'll correct the typos and resubmit with two separate commits . Thinh Tran
