Fri, May 10, 2024 at 09:20:51AM CEST, [email protected] wrote:
>On Thu, May 09, 2024 at 01:13:55PM +0200, Jiri Pirko wrote:
>> Tue, May 07, 2024 at 01:45:07PM CEST, [email protected] 
>> wrote:
>> >From: Piotr Raczynski <[email protected]>
>> >
>> >Implement subfunction driver. It is probe when subfunction port is
>> >activated.
>> >
>> >VSI is already created. During the probe VSI is being configured.
>> >MAC unicast and broadcast filter is added to allow traffic to pass.
>> >
>> >Store subfunction pointer in VSI struct. The same is done for VF
>> >pointer. Make union of subfunction and VF pointer as only one of them
>> >can be set with one VSI.
>> >
>> >Reviewed-by: Jiri Pirko <[email protected]>
>> >Signed-off-by: Piotr Raczynski <[email protected]>
>> >Signed-off-by: Michal Swiatkowski <[email protected]>
>> 
>> Perhaps it would make things clearer for reviewer to have all patches
>> related to sf auxdev/devlink/netdev at the end of the patchset, after
>> activation patch. Not sure why you want to mix it here.
>
>I need this code to use it in port representor implementation. You
>suggested in previous review to move activation at the end [1].

Yeah, I just thought that sfdev patches could be separate. Nevermind
then.

>
>[1] https://lore.kernel.org/netdev/Zhje0mQgQTMXwICb@nanopsycho/

Reply via email to