Re: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle SIOCSHWTSTAMP and SIOCGHWTSTAMP

[Keller, Jacob E]

> -----Original Message-----
> From: Jakub Kicinski <k...@kernel.org>
> Sent: Tuesday, May 28, 2024 1:01 PM
> To: Polchlopek, Mateusz <mateusz.polchlo...@intel.com>
> Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Keller, Jacob E
> <jacob.e.kel...@intel.com>; Drewek, Wojciech <wojciech.dre...@intel.com>;
> Rahul Rameshbabu <rrameshb...@nvidia.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v6 11/12] iavf: handle
> SIOCSHWTSTAMP and SIOCGHWTSTAMP
> 
> On Tue, 28 May 2024 07:23:00 -0400 Mateusz Polchlopek wrote:
> > +   .ndo_eth_ioctl          = iavf_do_ioctl,
> 
> Please use the new ndos:
> 
>  * int (*ndo_hwtstamp_get)(struct net_device *dev,
>  *                       struct kernel_hwtstamp_config *kernel_config);
>  *    Get the currently configured hardware timestamping parameters for the
>  *    NIC device.
>  *
>  * int (*ndo_hwtstamp_set)(struct net_device *dev,
>  *                       struct kernel_hwtstamp_config *kernel_config,
>  *                       struct netlink_ext_ack *extack);
>  *    Change the hardware timestamping parameters for NIC device.

+1, this is an excellent cleanup.

Thanks,
Jake