On Sat, Jun 01, 2024 at 12:24:14AM +0000, Keller, Jacob E wrote: > > > > -----Original Message----- > > From: Zaki, Ahmed <[email protected]> > > Sent: Friday, May 31, 2024 8:48 AM > > To: Simon Horman <[email protected]> > > Cc: [email protected]; [email protected]; Keller, Jacob > > E > > <[email protected]>; Nguyen, Anthony L <[email protected]>; > > Guo, Junfeng <[email protected]>; Marcin Szycik > > <[email protected]> > > Subject: Re: [PATCH iwl-next v2 11/13] ice: enable FDIR filters from raw > > binary > > patterns for VFs > > > > > > > > On 2024-05-31 7:18 a.m., Simon Horman wrote: > > > On Mon, May 27, 2024 at 12:58:08PM -0600, Ahmed Zaki wrote: > > >> From: Junfeng Guo <[email protected]> > > > > > > To me tweaking the order of includes seems to indicate > > > that something isn't quite right. Is there some sort of > > > dependency loop being juggled here? > > > > This was needed because of the changes in ice_flow.h, struct ice_vsi is > > now used. I will check if there is a better fix. > > > > I think there is probably a dependency loop. Ice has had a lot of issues > w.r.t. header includes ☹
Understood, let's leave that for another day :)
