On Tue, Jun 04, 2024 at 09:13:49AM -0400, Mateusz Polchlopek wrote: > From: Jacob Keller <[email protected]> > > Add support for allowing a VF to enable PTP feature - Rx timestamps > > The new capability is gated by VIRTCHNL_VF_CAP_PTP, which must be > set by the VF to request access to the new operations. In addition, the > VIRTCHNL_OP_1588_PTP_CAPS command is used to determine the specific > capabilities available to the VF. > > This support includes the following additional capabilities: > > * Rx timestamps enabled in the Rx queues (when using flexible advanced > descriptors) > * Read access to PHC time over virtchnl using > VIRTCHNL_OP_1588_PTP_GET_TIME > > Extra space is reserved in most structures to allow for future > extension (like set clock, Tx timestamps). Additional opcode numbers > are reserved and space in the virtchnl_ptp_caps structure is > specifically set aside for this. > Additionally, each structure has some space reserved for future > extensions to allow some flexibility. > > Signed-off-by: Jacob Keller <[email protected]> > Reviewed-by: Wojciech Drewek <[email protected]> > Reviewed-by: Rahul Rameshbabu <[email protected]> > Signed-off-by: Mateusz Polchlopek <[email protected]>
Hi Mateusz, Jacob, all, If you need to respin this for some reason, please consider updating the Kernel doc for the following to include a short description. Else, please consider doing so as a follow-up * struct virtchnl_ptp_caps * struct virtchnl_phc_time Likewise as a follow-up, as it was not introduced by this patch, for: * virtchnl_vc_validate_vf_msg Flagged by kernel-doc -none -Wall The above not withstanding, this looks good to me. Reviewed-by: Simon Horman <[email protected]> ...
