> This patch adds support for firmware update to the in-tree ixgbe driver and > it is actually a port > from the out-of-tree ixgbe driver. In-band firmware update is one of the > essential system maintenance …
Please improve such a change description also according to word wrapping because of more desirable text line lengths. … > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c > @@ -993,114 +993,292 @@ static void ixgbe_get_regs(struct net_device *netdev, … > +static int ixgbe_set_eeprom(struct net_device *netdev, > + struct ethtool_eeprom *eeprom, u8 *bytes) … > err: > - kfree(eeprom_buff); > - return ret_val; > + kfree(eeprom_buff); > + return ret_val; > } Please keep these statements unmodified. Would you like to reconsider the indentation once more for your change approach? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.10-rc2#n18 Regards, Markus
