> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Marcin Szycik > Sent: Friday, June 14, 2024 4:08 PM > To: [email protected] > Cc: Gardocki, PiotrX <[email protected]>; [email protected]; > Marcin Szycik <[email protected]>; Zaki, Ahmed > <[email protected]>; Kitszel, Przemyslaw <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next] ice: Distinguish driver reset and > removal for AQ shutdown > > From: Piotr Gardocki <[email protected]> > > Admin queue command for shutdown AQ contains a flag to indicate driver > unload. However, the flag is always set in the driver, even for resets. It > can cause the firmware to consider driver as unloaded once the PF reset is > triggered on all ports of device, which could lead to unexpected results. > > Add an additional function parameter to functions that shutdown AQ, > indicating whether the driver is actually unloading. > > Reviewed-by: Ahmed Zaki <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > Signed-off-by: Piotr Gardocki <[email protected]> > Signed-off-by: Marcin Szycik <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_common.h | 2 +- > drivers/net/ethernet/intel/ice/ice_controlq.c | 19 +++++++++++-------- > drivers/net/ethernet/intel/ice/ice_main.c | 6 +++--- > 3 files changed, 15 insertions(+), 12 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
