> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Simon > Horman > Sent: Friday, June 14, 2024 12:55 PM > To: Michal Swiatkowski <[email protected]> > Cc: [email protected]; Fijalkowski, Maciej <[email protected]>; > Polchlopek, Mateusz <[email protected]>; [email protected]; > [email protected]; [email protected]; Kubiak, Michal > <[email protected]>; [email protected]; > [email protected]; Samudrala, Sridhar <[email protected]>; > Keller, Jacob E <[email protected]>; Drewek, Wojciech > <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Subject: Re: [Intel-wired-lan] [iwl-next v5 05/15] ice: allocate devlink for > subfunction > > On Thu, Jun 06, 2024 at 01:24:53PM +0200, Michal Swiatkowski wrote: > > From: Piotr Raczynski <[email protected]> > > > > Make devlink allocation function generic to use it for PF and for SF. > > > > Add function for SF devlink port creation. It will be used in next > > patch. > > > > Create header file for subfunction device. Define subfunction device > > structure there as it is needed for devlink allocation and port > > creation. > > > > Reviewed-by: Przemek Kitszel <[email protected]> > > Signed-off-by: Piotr Raczynski <[email protected]> > > Signed-off-by: Michal Swiatkowski <[email protected]> > > Thanks Piotr, > > I believe this addresses Jiri's review of v4. > And the minor nit below not withstanding, this looks good to me. > > Reviewed-by: Simon Horman <[email protected]> > > ... > > > diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c > > b/drivers/net/ethernet/intel/ice/devlink/devlink.c > > ... >
Tested-by: Rafal Romanowski <[email protected]>
