> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Simon Horman > Sent: Friday, July 26, 2024 9:16 AM > To: Lobakin, Aleksander <[email protected]> > Cc: Linga, Pavan Kumar <[email protected]>; NEX SW NCIS OSDT ITP > Upstreaming <[email protected]>; > [email protected]; [email protected]; [email protected]; > Eric Dumazet <[email protected]>; Kubiak, Michal > <[email protected]>; Nguyen, Anthony L > <[email protected]>; Jakub Kicinski <[email protected]>; intel-wired- > [email protected]; Paolo Abeni <[email protected]>; David S. Miller > <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-net 2/3] idpf: fix memleak in vport > interrupt configuration > > On Wed, Jul 24, 2024 at 03:40:23PM +0200, Alexander Lobakin wrote: > > From: Michal Kubiak <[email protected]> > > > > The initialization of vport interrupt consists of two functions: > > 1) idpf_vport_intr_init() where a generic configuration is done > > 2) idpf_vport_intr_req_irq() where the irq for each q_vector is > > requested. > > > > The first function used to create a base name for each interrupt using > > "kasprintf()" call. Unfortunately, although that call allocated memory > > for a text buffer, that memory was never released. > > > > Fix this by removing creating the interrupt base name in 1). > > Instead, always create a full interrupt name in the function 2), because > > there is no need to create a base name separately, considering that the > > function 2) is never called out of idpf_vport_intr_init() context. > > > > Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport") > > Cc: [email protected] # 6.7 > > Signed-off-by: Michal Kubiak <[email protected]> > > Reviewed-by: Pavan Kumar Linga <[email protected]> > > Signed-off-by: Alexander Lobakin <[email protected]> > > Reviewed-by: Simon Horman <[email protected]>
Tested-by: Krishneil Singh <[email protected]>
