Dear Christopher,
Thank you for your patch.
In the summary, I’d add specific values:
igc: Reduce retry count to from 100 to reasonable 8
Am 07.08.24 um 02:30 schrieb [email protected]:
From: Christopher S M Hall <[email protected]>
Setting the retry count to 8x is more than sufficient. 100x is unreasonable
and would indicate broken hardware/firmware.
I’d remove the leading space.
Is using a 100 causing so much more delay and debugging an issue is harder?
Fixes: a90ec8483732 ("igc: Add support for PTP getcrosststamp()")
Signed-off-by: Christopher S M Hall <[email protected]>
---
drivers/net/ethernet/intel/igc/igc_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c
b/drivers/net/ethernet/intel/igc/igc_ptp.c
index fb885fcaa97c..f770e39650ef 100644
--- a/drivers/net/ethernet/intel/igc/igc_ptp.c
+++ b/drivers/net/ethernet/intel/igc/igc_ptp.c
@@ -1008,8 +1008,8 @@ static int igc_phc_get_syncdevicetime(ktime_t *device,
u32 stat, t2_curr_h, t2_curr_l;
struct igc_adapter *adapter = ctx;
struct igc_hw *hw = &adapter->hw;
- int err, count = 100;
ktime_t t1, t2_curr;
+ int err, count = 8;
Is there data available that no more than 8 retries were needed?
/* Doing this in a loop because in the event of a
* badly timed (ha!) system clock adjustment, we may
Kind regards,
Paul
