>-----Original Message-----
>From: Intel-wired-lan <[email protected]> On Behalf Of
>Zaremba, Larysa
>Sent: Wednesday, July 24, 2024 10:19 PM
>To: [email protected]
>Cc: Drewek, Wojciech <[email protected]>; Fijalkowski, Maciej
><[email protected]>; Jesper Dangaard Brouer <[email protected]>;
>Daniel Borkmann <[email protected]>; Zaremba, Larysa
><[email protected]>; [email protected]; John Fastabend
><[email protected]>; Alexei Starovoitov <[email protected]>; linux-
>[email protected]; Eric Dumazet <[email protected]>; Kubiak,
>Michal <[email protected]>; Nguyen, Anthony L
><[email protected]>; Nambiar, Amritha
><[email protected]>; Keller, Jacob E <[email protected]>;
>Jakub Kicinski <[email protected]>; [email protected]; Paolo Abeni
><[email protected]>; David S. Miller <[email protected]>; Karlsson,
>Magnus <[email protected]>
>Subject: [Intel-wired-lan] [PATCH iwl-net v2 5/6] ice: remove ICE_CFG_BUSY
>locking from AF_XDP code
>
>Locking used in ice_qp_ena() and ice_qp_dis() does pretty much nothing,
>because ICE_CFG_BUSY is a state flag that is supposed to be set in a PF state,
>not VSI one. Therefore it does not protect the queue pair from e.g. reset.
>
>Despite being useless, it still can deadlock the unfortunate functions that
>have
>fell into the same ICE_CFG_BUSY-VSI trap. This happens if ice_qp_ena returns
>an error.
>
>Remove ICE_CFG_BUSY locking from ice_qp_dis() and ice_qp_ena().
>
>Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
>Reviewed-by: Wojciech Drewek <[email protected]>
>Signed-off-by: Larysa Zaremba <[email protected]>
>---
> drivers/net/ethernet/intel/ice/ice_xsk.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
Tested-by: Chandan Kumar Rout <[email protected]> (A Contingent Worker at
Intel)
