> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Jacob > Keller > Sent: Wednesday, August 7, 2024 2:16 AM > To: Nguyen, Anthony L <[email protected]>; Intel Wired LAN > <[email protected]>; "netdev netdev"@vger.kernel.org > Cc: Temerkhanov, Sergey <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Kolacinski, Karol > <[email protected]>; Wierzbicki, Jacek <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next 2/7] ice: improve debug print for > control queue messages > > The ice_debug_cq function is called to print debug data for a control queue > descriptor in multiple places. This includes both before we send a message on > a transmit queue, after the writeback completion of a message on the transmit > queue, and when we receive a message > on a receive queue. > > This function does not include data about *which* control queue the message > is on, nor whether it was what we sent to the queue or what we received from > the queue. > > Modify ice_debug_cq to take two extra parameters, a pointer to the control > queue and a boolean indicating if this was a response or a command. Improve > the debug messages by replacing "CQ CMD" with a string indicating which > specific control queue (based on cq->qtype) > and whether this was a command > sent by the PF or a response from the queue. > > This helps make the log output easier to understand and consume when > debugging. > > Signed-off-by: Jacob Keller <[email protected]> > Reviewed-by: Przemek Kitszel <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_controlq.c | 36 > +++++++++++++++++++++++---- > 1 file changed, 31 insertions(+), 5 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
