On 13.08.2024 21:24, Maciej Fijalkowski wrote:
On Tue, Aug 13, 2024 at 05:31:37PM +0200, Dawid Osuchowski wrote:
On 13.08.2024 13:49, Maciej Fijalkowski wrote:
What about other intel drivers tho?
I have not performed detailed analysis of other intel ethernet drivers in
this regard, but it is surely a topic worth investigating.
If you could take some action upon this then it would be great. I'm always
hesitating with providing the review tag against a change that already
contains few of them, but given that I dedicated some time to look into
that:
I got a valid concern from Kalesh (CCd) on the v1 thread
(https://lore.kernel.org/netdev/cah-l+nofqs-k5yzfrfmprhbhdgm-+1ahhwh4nxatx1fqzip...@mail.gmail.com/)
about the attaching only if link is up.
On 14.08.2024 05:19, Kalesh Anakkur Purayil wrote:
> [Kalesh] Is there any reason to attach back the netdev only if link is
> up? IMO, you should attach the device back irrespective of physical
> link status. In ice_prepare_for_reset(), you are detaching the device
> unconditionally.
>
> I may be missing something here.
I agree with his suggestion to do the netif_device_attach() irrespective
of link being up. Should I sent a v3 with the change? I have already
tested that locally and it seems to fix the reported issue with NULL
pointer dereference as well.
--Dawid
Reviewed-by: Maciej Fijalkowski <[email protected]>
--Dawid
