> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Kurt > Kanzenbach > Sent: Thursday, August 22, 2024 12:42 AM > To: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Cc: Jesper Dangaard Brouer <[email protected]>; Daniel Borkmann > <[email protected]>; Sriram Yagnaraman > <[email protected]>; Sebastian Andrzej Siewior > <[email protected]>; Kurt Kanzenbach <[email protected]>; John Fastabend > <[email protected]>; Alexei Starovoitov <[email protected]>; Sriram > Yagnaraman <[email protected]>; Benjamin Steinke > <[email protected]>; Eric Dumazet <[email protected]>; > [email protected]; Fijalkowski, Maciej <[email protected]>; > intel- > [email protected]; Jakub Kicinski <[email protected]>; > [email protected]; Paolo Abeni <[email protected]>; David S. Miller > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net] igb: Always call > igb_xdp_ring_update_tail() > under Tx lock > > From: Sriram Yagnaraman <[email protected]> > > Always call igb_xdp_ring_update_tail() under __netif_tx_lock, add a comment > and > lockdep assert to indicate that. This is needed to share the same TX ring > between > XDP, XSK and slow paths. Furthermore, the current XDP implementation is racy > on > tail updates. > > Fixes: 9cbc948b5a20 ("igb: add XDP support") > Signed-off-by: Sriram Yagnaraman <[email protected]> > [Kurt: Add lockdep assert and fixes tag] > Signed-off-by: Kurt Kanzenbach <[email protected]> > --- > drivers/net/ethernet/intel/igb/igb_main.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) >
Tested-by: George Kuruvinakunnel <[email protected]>
