> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Arkadiusz Kubalewski > Sent: Thursday, September 12, 2024 2:24 PM > To: [email protected] > Cc: Loktionov, Aleksandr <[email protected]>; Paul Menzel > <[email protected]>; Kubalewski, Arkadiusz > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net v2] ice: disallow > DPLL_PIN_STATE_SELECTABLE for dpll output pins > > Currently the user may request DPLL_PIN_STATE_SELECTABLE for an output pin, > and this would actually set the DISCONNECTED state instead. > > It doesn't make any sense. SELECTABLE is valid only in case of input pins (on > AUTOMATIC type dpll), where dpll itself would select best valid input. > For the output pin only CONNECTED/DISCONNECTED are expected. > > Fixes: d7999f5ea64b ("ice: implement dpll interface to control cgu") > Reviewed-by: Aleksandr Loktionov <[email protected]> > Reviewed-by: Paul Menzel <[email protected]> > Signed-off-by: Arkadiusz Kubalewski <[email protected]> > --- > v2: > - use more explicit commit title > - add empty line between commit message paragraphs > --- > drivers/net/ethernet/intel/ice/ice_dpll.c | 2 ++ > 1 file changed, 2 insertions(+) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
