> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Larysa Zaremba > Sent: Wednesday, September 4, 2024 2:54 AM > To: [email protected]; Nguyen, Anthony L > <[email protected]> > Cc: Tantilov, Emil S <[email protected]>; Zaremba, Larysa > <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Hay, Joshua A <[email protected]>; > [email protected]; Bagnucki, Igor <[email protected]>; > Lobakin, Aleksander <[email protected]>; Eric Dumazet > <[email protected]>; Kubiak, Michal <[email protected]>; Alan > Brady <[email protected]>; [email protected]; Jakub Kicinski > <[email protected]>; Paolo Abeni <[email protected]>; David S. Miller > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net] idpf: deinit virtchnl transaction > manager after vport and vectors > > When the device is removed, idpf is supposed to make certain virtchnl > requests e.g. VIRTCHNL2_OP_DEALLOC_VECTORS and > VIRTCHNL2_OP_DESTROY_VPORT. > > However, this does not happen due to the referenced commit introducing > virtchnl transaction manager and placing its deinitialization before those > messages are sent. Then the sending is impossible due to no transactions > being available. > > Lack of cleanup can lead to the FW becoming unresponsive from e.g. > unloading-loading the driver and creating-destroying VFs afterwards. > > Move transaction manager deinitialization to after other virtchnl-related > cleanup is done. > > Fixes: 34c21fa894a1 ("idpf: implement virtchnl transaction manager") > Reviewed-by: Przemek Kitszel <[email protected]> > Signed-off-by: Larysa Zaremba <[email protected]> > --- > drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > index a5f9b7a5effe..f18f490dafd8 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c > +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
Tested-by: Krishneil Singh <[email protected]>
