> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Marcin Szycik > Sent: Tuesday, September 24, 2024 3:34 PM > To: [email protected] > Cc: Fijalkowski, Maciej <[email protected]>; > [email protected]; Polchlopek, Mateusz <[email protected]>; > Marcin Szycik <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; [email protected] > Subject: [Intel-wired-lan] [PATCH iwl-net v3 1/2] ice: Fix entering Safe Mode > > If DDP package is missing or corrupted, the driver should enter Safe Mode. > Instead, an error is returned and probe fails. > > To fix this, don't exit init if ice_init_ddp_config() returns an error. > > Repro: > * Remove or rename DDP package (/lib/firmware/intel/ice/ddp/ice.pkg) > * Load ice > > Fixes: cc5776fe1832 ("ice: Enable switching default Tx scheduler topology") > Reviewed-by: Przemek Kitszel <[email protected]> > Signed-off-by: Marcin Szycik <[email protected]> > --- > v3: Change ice_init_ddp_config() type to int, check return (Brett) > v2: Change ice_init_ddp_config() type to void (Maciej) > --- > drivers/net/ethernet/intel/ice/ice_main.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
