On Tue, Oct 01, 2024 at 11:52:34PM +0000, Joe Damato wrote: [...]
> Note that idpf has embedded napi_struct in its internals and has > established some series of asserts that involve the size of napi > structure. Since this change increases the napi_struct size from 400 to > 416 (according to pahole on my system), I've increased the assertion in > idpf by 16 bytes. No attention whatsoever was paid to the cacheline > placement of idpf internals as a result of this change. > > Signed-off-by: Joe Damato <[email protected]> > --- > .../networking/net_cachelines/net_device.rst | 2 +- > drivers/net/ethernet/intel/idpf/idpf_txrx.h | 2 +- > include/linux/netdevice.h | 3 +- > net/core/dev.c | 12 +++--- > net/core/dev.h | 40 +++++++++++++++++++ > net/core/net-sysfs.c | 2 +- > 6 files changed, 51 insertions(+), 10 deletions(-) [...] > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.h > b/drivers/net/ethernet/intel/idpf/idpf_txrx.h > index f0537826f840..fcdf73486d46 100644 > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.h > +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.h > @@ -438,7 +438,7 @@ struct idpf_q_vector { > __cacheline_group_end_aligned(cold); > }; > libeth_cacheline_set_assert(struct idpf_q_vector, 112, > - 424 + 2 * sizeof(struct dim), > + 440 + 2 * sizeof(struct dim), > 8 + sizeof(cpumask_var_t)); > > struct idpf_rx_queue_stats { Now that idpf was fixed separately [1], this will be removed in the v5. [1]: https://lore.kernel.org/netdev/[email protected]/
