On 01/10/2024 20:05, Vitaly Lifshits wrote:
Since the igc driver doesn't support forced speed configuration and
its current related hardware doesn't support it either, there is no
use of the mac.autoneg parameter. Moreover, in one case this usage
might result in a NULL pointer dereference due to an uninitialized
function pointer, phy.ops.force_speed_duplex.
Therefore, remove this parameter from the igc code.
Signed-off-by: Vitaly Lifshits <[email protected]>
---
drivers/net/ethernet/intel/igc/igc_diag.c | 3 +-
drivers/net/ethernet/intel/igc/igc_ethtool.c | 13 +-
drivers/net/ethernet/intel/igc/igc_hw.h | 1 -
drivers/net/ethernet/intel/igc/igc_mac.c | 316 +++++++++----------
drivers/net/ethernet/intel/igc/igc_main.c | 1 -
drivers/net/ethernet/intel/igc/igc_phy.c | 24 +-
6 files changed, 163 insertions(+), 195 deletions(-)
Tested-by: Mor Bar-Gabay <[email protected]>
