From: Intel-wired-lan <[email protected]> on behalf of Michal Swiatkowski <[email protected]> Sent: Friday, October 4, 2024 8:55 AM To: [email protected] <[email protected]> Cc: [email protected] <[email protected]>; Kitszel, Przemyslaw <[email protected]> Subject: [Intel-wired-lan] [iwl-net v1] ice: block SF port creation in legacy mode There is no support for SF in legacy mode. Reflect it in the code.
Reviewed-by: Przemek Kitszel <[email protected]> Fixes: eda69d654c7e ("ice: add basic devlink subfunctions support") Signed-off-by: Michal Swiatkowski <[email protected]> --- drivers/net/ethernet/intel/ice/devlink/devlink_port.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink_port.c b/drivers/net/ethernet/intel/ice/devlink/devlink_port.c index 928c8bdb6649..c6779d9dffff 100644 --- a/drivers/net/ethernet/intel/ice/devlink/devlink_port.c +++ b/drivers/net/ethernet/intel/ice/devlink/devlink_port.c @@ -989,5 +989,11 @@ ice_devlink_port_new(struct devlink *devlink, if (err) return err; + if (!ice_is_eswitch_mode_switchdev(pf)) { + NL_SET_ERR_MSG_MOD(extack, + "SF ports are only supported in eswitch switchdev mode"); + return -EOPNOTSUPP; + } + return ice_alloc_dynamic_port(pf, new_attr, extack, devlink_port); } -- 2.42.0 Tested-by: Rafal Romanowski <[email protected]>
