On 10/17/2024 1:58 AM, Diomidis Spinellis wrote:
> Header ixgbe_type.h includes ixgbe_mbx.h. Also, header
> ixgbe_mbx.h included ixgbe_type.h, thus introducing a circular
> dependency.
>
> - Remove ixgbe_mbx.h inclusion from ixgbe_type.h.
>
> - ixgbe_mbx.h requires the definition of struct ixgbe_mbx_operations
> so move its definition there. While at it, add missing argument
> identifier names.
>
> - Add required forward structure declarations.
>
> - Include ixgbe_mbx.h in the .c files that need it, for the
> following reasons:
>
> ixgbe_sriov.c uses ixgbe_check_for_msg
> ixgbe_main.c uses ixgbe_init_mbx_params_pf
> ixgbe_82599.c uses mbx_ops_generic
> ixgbe_x540.c uses mbx_ops_generic
> ixgbe_x550.c uses mbx_ops_generic
>
> Signed-off-by: Diomidis Spinellis <[email protected]>
> ---
The changes make sense. Which tree was this aimed at? I'd guess as a
cleanup without direct impact that its aimed at next?
Reviewed-by: Jacob Keller <[email protected]>
Thanks,
Jake
