On Mon, Nov 4, 2024 at 4:40 PM Michal Schmidt <[email protected]> wrote: > > On Tue, Oct 29, 2024 at 1:36 PM Aleksandr Loktionov > <[email protected]> wrote: [...] > > + > > + i40e_vc_reset_vf(vf, true); > > } > > } > > > > /* re-enable mdd interrupt cause */ > > clear_bit(__I40E_MDD_EVENT_PENDING, pf->state); > > Can you remove this 2nd clearing of the __I40E_MDD_EVENT_PENDING bit? > If the interrupt handler detects a MDD event while we're still > printing the message about the previous one, we don't want to forget > it by clearing it here. > > Michal
Well, I suppose the race I described cannot happen because the unmasking of ..._MAL_DETECT_MASK happens after this. But it's still redundant to clear the bit twice. Michal > > reg = rd32(hw, I40E_PFINT_ICR0_ENA); > > reg |= I40E_PFINT_ICR0_ENA_MAL_DETECT_MASK; > > wr32(hw, I40E_PFINT_ICR0_ENA, reg); > > i40e_flush(hw); > > + > > + i40e_print_vfs_mdd_events(pf); > > } > > > > /**
