> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Jacob > Keller > Sent: Tuesday, November 5, 2024 11:50 PM > To: Paul Menzel <[email protected]> > Cc: [email protected]; Yifei Liu <[email protected]>; > Kitszel, > Przemyslaw <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-net 2/2] ixgbe: downgrade logging of > unsupported VF API version to debug > > > > On 11/1/2024 11:53 PM, Paul Menzel wrote: > > Dear Jacob, > > > > > > Thank you for the patch. > > > > Am 02.11.24 um 00:05 schrieb Jacob Keller: > >> The ixgbe PF driver logs an info message when a VF attempts to > >> negotiate an API version which it does not support: > >> > >> VF 0 requested invalid api version 6 > >> > >> The ixgbevf driver attempts to load with mailbox API v1.5, which is > >> required for best compatibility with other hosts such as the ESX VMWare PF. > >> > >> The Linux PF only supports API v1.4, and does not currently have > >> support for the v1.5 API. > >> > >> The logged message can confuse users, as the v1.5 API is valid, but > >> just happens to not currently be supported by the Linux PF. > >> > >> Downgrade the info message to a debug message, and fix the language > >> to use 'unsupported' instead of 'invalid' to improve message clarity. > >> > >> Long term, we should investigate whether the improvements in the v1.5 > >> API make sense for the Linux PF, and if so implement them properly. > >> This may require yet another API version to resolve issues with > >> negotiating IPSEC offload support. > > > > It’d be great if you described the exact test setup for how to reproduce it. > > > >> Reported-by: Yifei Liu <[email protected]> > > > > Do you have an Link: for this report? > > > >> Signed-off-by: Jacob Keller <[email protected]> > >> Reviewed-by: Przemek Kitszel <[email protected]> > >> --- > >> drivers/net/ethernet/intel/ixgbe/ixgbe_common.h | 2 ++ > >> drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +- > >> 2 files changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.h > >> b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.h > >> index 6493abf189de..6639069ad528 100644 > >> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.h > >> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.h > >> @@ -194,6 +194,8 @@ u32 ixgbe_read_reg(struct ixgbe_hw *hw, u32 reg);
Tested-by: Rafal Romanowski <[email protected]>
