>-----Original Message-----
>From: Intel-wired-lan <[email protected]> On Behalf Of
>Fijalkowski, Maciej
>Sent: Thursday, January 23, 2025 8:31 PM
>To: [email protected]
>Cc: Fijalkowski, Maciej <[email protected]>;
>[email protected]; [email protected]; Nguyen, Anthony L
><[email protected]>; Simon Horman <[email protected]>; Kitszel,
>Przemyslaw <[email protected]>; Keller, Jacob E
><[email protected]>; Maxwell, Jon <[email protected]>; Karlsson,
>Magnus <[email protected]>
>Subject: [Intel-wired-lan] [PATCH v5 iwl-net 3/3] ice: stop storing XDP verdict
>within ice_rx_buf
>
>Idea behind having ice_rx_buf::act was to simplify and speed up the Rx data
>path by walking through buffers that were representing cleaned HW Rx
>descriptors. Since it caused us a major headache recently and we rolled back to
>old approach that 'puts' Rx buffers right after running XDP prog/creating skb,
>this is useless now and should be removed.
>
>Get rid of ice_rx_buf::act and related logic. We still need to take care of a
>corner
>case where XDP program releases a particular fragment.
>
>Make ice_run_xdp() to return its result and use it within ice_put_rx_mbuf().
>
>Fixes: 2fba7dc5157b ("ice: Add support for XDP multi-buffer on Rx side")
>Reviewed-by: Przemek Kitszel <[email protected]>
>Reviewed-by: Simon Horman <[email protected]>
>Signed-off-by: Maciej Fijalkowski <[email protected]>
>---
> drivers/net/ethernet/intel/ice/ice_txrx.c | 62 +++++++++++--------
> drivers/net/ethernet/intel/ice/ice_txrx.h | 1 -
> drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 43 -------------
> 3 files changed, 36 insertions(+), 70 deletions(-)
>
Tested-by: Chandan Kumar Rout <[email protected]> (A Contingent Worker at
Intel)
