> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Mateusz Polchlopek > Sent: 17 January 2025 13:37 > To: [email protected] > Cc: [email protected]; Polchlopek, Mateusz > <[email protected]>; Michal Swiatkowski > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next v1] ice: refactor > ice_fdir_create_dflt_rules() function > > The Flow Director function ice_fdir_create_dflt_rules() calls few times > function ice_create_init_fdir_rule() each time with different enum > ice_fltr_ptype parameter. Next step is to return error code if error occurred. > > Change the code to store all necessary default rules in constant array and > call ice_create_init_fdir_rule() in the loop. It makes it easy to extend the > list of default rules in the future, without the need of duplicate code more > and more. > > Reviewed-by: Michal Swiatkowski <[email protected]> > Signed-off-by: Mateusz Polchlopek <[email protected]> > --- > .../net/ethernet/intel/ice/ice_ethtool_fdir.c | 21 ++++++++----------- > 1 file changed, 9 insertions(+), 12 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
